Filmography
| Year | Title | Role |
| 1976 | The Shootist | John Bernard Books |
| 1975 | Rooster Cogburn | Rooster Cogburn |
| 1975 | Brannigan | Lt. Brannigan |
| 1974 | McQ | McQ |
| 1973 | Cahill: Us Marshal | J.D. Cahill |
| 1972 | The Cowboys | Wil Andersen |
| 1972 | Letter to Jane: An Investigation About a Still | Self |
| 1972 | Cancel My Reservation | Self |
| 1971 | Big Jake | Jacob McCandles |
| 1970 | Rio Lobo | Col. Cord McNally |
| 1970 | Chisum | John Chisum |
| 1969 | The Undefeated (1969) | Col. John Henry Thomas |
| 1969 | True Grit (1969) | Rooster Cogburn |
| 1968 | The Green Berets | Col. Mike Kirby |
| 1967 | The War Wagon | Taw Jackson |
| 1966 | Cast a Giant Shadow | Gen. Mike Randolph |
| 1966 | El Dorado (1967) | Cole Thornton |
| 1965 | The Sons of Katie Elder | John Elder |
| 1965 | In Harm's Way (1965) | Capt. Rockwell Torrey |
| 1965 | The Greatest Story Ever Told | Centurion at crucifixion |
| 1963 | Donovan's Reef | Michael Patrick "Guns" Donovan |
| 1963 | McLintock! | George Washington McLintock |
| 1962 | How the West Was Won | Gen. William Tecumseh Sherman |
| 1962 | The Man Who Shot Liberty Valance (1962) | Tom Doniphon |
| 1962 | The Longest Day | Lt. Col. Benjamin Vandervoort |
| 1962 | ¡Hatari! | Sean Mercer |
| 1961 | The Comancheros | Ranger Capt. Jake Cutter |
| 1960 | North to Alaska | Sam McCord |
| 1960 | The Alamo | Col. Davy Crockett |
| 1959 | Rio Bravo | Sheriff John T. Chance |
| 1959 | The Horse Soldiers | Col. John Marlowe |
| 1958 | The Barbarian and the Geisha | Townsend Harris |
| 1957 | Jet Pilot | Col. Jim Shannon |
| 1957 | The Wings of Eagles | Frank W. "Spig" Wead |
| 1957 | Legend of the Lost | Joe January |
| 1956 | The Searchers (1956) | Ethan Edwards |
| 1956 | The Conqueror | Temujin/Genghis Khan |
| 1956 | Good-bye, My Lady | Producer |
| 1955 | Blood Alley | Capt. Tom Wilder |
| 1955 | The Sea Chase | Captain Karl Ehrlich |
| 1954 | Track of the Cat | Producer |
| 1954 | The High and the Mighty | Dan Roman |
| 1953 | Hondo | Hondo Lane |
| 1953 | Island in the Sky | Captain Dooley |
| 1952 | The Quiet Man | Sean Thornton |
| 1951 | Flying Leathernecks | Maj. Daniel Xavier Kirby |
| 1951 | Operation Pacific | Lt Cmdr. Duke E. Gifford |
| 1950 | The Bullfighter and the Lady | Producer |
| 1950 | Rio Grande | Lt. Col. Kirby York |
| 1949 | Sands of Iwo Jima | Sgt. John M. Stryker |
| 1949 | She Wore a Yellow Ribbon | Captain Nathan Cutting Brittles |
| 1948 | Fort Apache | Capt. Kirby York |
| 1948 | Red River (1948) | Thomas Dunson |
| 1948 | 3 Godfathers | Robert Marmaduke Hightower |
| 1948 | Wake of the Red Witch | Capt. Ralls |
| 1947 | Angel and the Badman | Quirt Evans |
| 1947 | Tycoon | Johnny Munroe |
| 1946 | Without Reservations | Rusty |
| 1945 | They Were Expendable | Lt. (j.g.) "Rusty" Ryan |
| 1945 | Back to Bataan | Col. Joseph Madden |
| 1944 | The Fighting Seabees | Lt. Cmdr. Wedge Donovan |
| 1943 | A Lady Takes a Chance | Duke Hudkins |
| 1942 | Reap the Wild Wind | Captain Jack Stuart |
| 1942 | Reunion in France | Pat Talbot |
| 1942 | Flying Tigers | Capt. Jim Gordon |
| 1941 | The Shepherd of the Hills | Young Matt |
| 1940 | Seven Sinners | Lt. Dan Brent |
| 1940 | The Dark Command | Bob Seton |
| 1940 | The Long Voyage Home | Olsen |
| 1940 | Three Faces West | John Phillips |
| 1939 | Stagecoach (1939) | The Ringo Kid aka Henry |
| 1939 | New Frontier | Stony Brooke |
| 1939 | Allegheny Uprising | James Smith |
| 1938 | Overland Stage Raiders | Stony Brooke |
| 1938 | Hell Town | Dare Rudd |
| 1937 | Adventure's End | Duke Slade |
| 1936 | Winds of the Wasteland | John Blair |
| 1935 | The Lawless Frontier | John Tobin |
| 1935 | Texas Terror | John Higgins |
| 1935 | Paradise Canyon | John Wyatt/John Rogers |
| 1935 | The New Frontier (1935) | John |
| 1934 | The Trail Beyond | Rod Drew |
| 1934 | The Lucky Texan | Jerry Mason |
| 1934 | The Man From Utah | John Weston |
| 1934 | 'Neath the Arizona Skies | Chris Morrell |
| 1934 | Randy Rides Alone | Randy Bowers |
| 1934 | The Star Packer | U.S. Marshal John Travers |
| 1933 | Baby Face | Jimmy McCoy Jr. |
| 1933 | Sagebrush Trail | John Brant |
| 1933 | Central Airport | Co-Pilot in Wreck |
| 1933 | His Private Secretary | Dick Wallace |
| 1932 | The Hurricane Express | Larry Baker |
| 1931 | Girls Demand Excitement | Peter Brooks |
| 1931 | Arizona (1931) | Lt. Bob Denton |
| 1931 | The Range Feud | Clint Turner |
| 1930 | The Big Trail | Breck Coleman |
| 1927 | The Drop Kick | Football Player/Extra in Stands |
